fix: properly update 'label' field for helm + render w/ -l flag #7349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7336
Before this change:
After this change (the output shown is the change backported onto v1.37.1, currently there is no helm renderer in V2 IIUC. See - https://github.com/GoogleContainerTools/skaffold/blob/main/pkg/skaffold/render/renderer/noop/noop.go#L30):
The changes for the V2 Helm ->
Render
method are nearly identical to what is done in V1. I understand in V2 this code is not used but the Helm deployer is TODO and IIUC likely re-using parts of theRender
method will be done so it makes sense to get this in now so it will also be in the helm renderer implementation