fix: cloud build cannot find private workerpool issue #7356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-prindle
approved these changes
Apr 29, 2022
Codecov Report
@@ Coverage Diff @@
## release/v1.37.2 #7356 +/- ##
==================================================
Coverage ? 68.37%
==================================================
Files ? 560
Lines ? 26542
Branches ? 0
==================================================
Hits ? 18149
Misses ? 7134
Partials ? 1259 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
aaron-prindle
deleted the
fix-cloud-build-cannot-find-private-workerpool
branch
aaron-prindle
pushed a commit
that referenced
this pull request
Apr 29, 2022
aaron-prindle
pushed a commit
to aaron-prindle/skaffold
that referenced
this pull request
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7340
Related: #6666 #7347
Description
User facing changes (remove if N/A)
skaffold is not able to find private worker pool when using could build.
linters doesn't work on go1.18.1 https://gist.github.com/ericzzzzzzz/f80cbdbe93cf2860235bcbbfb7d22697