Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add privateWorkerPool and location configuration for gcb #7440

Merged

Conversation

ericzzzzzzz
Copy link
Contributor

Fixes: #7342

Description

  • cherry-pick privateWorkerPool support from main
  • cherry-pick region configuration in googleCouldBuild support from main
  • implement change to support configure the region, if workerPool is configured, build location is still deduced from workerPool. If not and region is configured, region in the configuration will be used as build location.

User facing changes

  • Add privateWorkerPool and region configuration for gcb, so users are able to configure region to run gcb

Test Plan

  • change this line to MarkIntegrationTest(t, CanRunWithoutGcp) then manually run this test
  • enter gcp console, select k8s-skaffold project, then check the build history from asia-east1, should be able to find the build detail.

@ericzzzzzzz ericzzzzzzz requested a review from a team as a code owner May 24, 2022 21:17
@ericzzzzzzz ericzzzzzzz requested review from renzodavid9 and removed request for a team May 24, 2022 21:17
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

❗ No coverage uploaded for pull request base (v1@a3e0b76). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             v1    #7440   +/-   ##
=====================================
  Coverage      ?   68.04%           
=====================================
  Files         ?      566           
  Lines         ?    26671           
  Branches      ?        0           
=====================================
  Hits          ?    18148           
  Misses        ?     7240           
  Partials      ?     1283           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@tejal29 tejal29 merged commit 5c7b99d into GoogleContainerTools:v1 May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants