Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ko): Inferred file sync for ko static assets #7728

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

halvards
Copy link
Collaborator

@halvards halvards commented Aug 3, 2022

This change adds inferred file sync mode to the ko builder.

Skaffold syncs static assets from the workspace to a running container, based on the <importpath>/kodata/ convention: https://github.com/google/ko#static-assets

Tracking: #7131

@halvards halvards force-pushed the ko-file-sync branch 2 times, most recently from be3d889 to 2bc1325 Compare August 3, 2022 13:59
This change adds inferred file sync mode to the ko builder.

Skaffold syncs static assets from the workspace to a running
container, based on the `<importpath>/kodata/` convention:
https://github.com/google/ko#static-assets

Tracking: GoogleContainerTools#7131
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #7728 (260cdfc) into main (290280e) will decrease coverage by 3.76%.
The diff coverage is 53.59%.

@@            Coverage Diff             @@
##             main    #7728      +/-   ##
==========================================
- Coverage   70.48%   66.71%   -3.77%     
==========================================
  Files         515      588      +73     
  Lines       23150    28293    +5143     
==========================================
+ Hits        16317    18877    +2560     
- Misses       5776     8040    +2264     
- Partials     1057     1376     +319     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 347 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass review. Will look through the code in detail later this week.

@tejal29 tejal29 merged commit 0029055 into GoogleContainerTools:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants