Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add multi platform integration tests #7852

Conversation

renzodavid9
Copy link
Contributor

@renzodavid9 renzodavid9 commented Sep 8, 2022

Fixes: #7863 #7868

Description
Integration tests for run, dev, debug, and deploy commands with multi-platform

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #7852 (8c42110) into main (290280e) will decrease coverage by 3.87%.
The diff coverage is 53.94%.

@@            Coverage Diff             @@
##             main    #7852      +/-   ##
==========================================
- Coverage   70.48%   66.61%   -3.88%     
==========================================
  Files         515      593      +78     
  Lines       23150    28698    +5548     
==========================================
+ Hits        16317    19116    +2799     
- Misses       5776     8169    +2393     
- Partials     1057     1413     +356     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 362 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 force-pushed the add-multi-platform-integration-tests branch 3 times, most recently from ffcbd29 to f2ffccd Compare September 15, 2022 17:00
Copy link
Collaborator

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@renzodavid9 renzodavid9 force-pushed the add-multi-platform-integration-tests branch 3 times, most recently from b07dc7f to 8a8d78a Compare September 19, 2022 16:55
@renzodavid9 renzodavid9 changed the title test: Add multi platform integration tests <NOT MERGE> test: Add multi platform integration tests Sep 19, 2022
@renzodavid9 renzodavid9 marked this pull request as ready for review September 19, 2022 17:10
@gsquared94 gsquared94 added the kokoro:force-run forces a kokoro re-run on a PR label Sep 21, 2022
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Sep 21, 2022
@gsquared94
Copy link
Collaborator

/rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write integration test for running dev and debug against the mixed-node test cluster.
4 participants