Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add inputDigest tagger alias to customTemplate tagger #7867

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

mikekamornikov
Copy link
Contributor

Fixes: #7865

Description
It modifies customTemplate tagger to support inputDigest by default:

  • Given template is parsed to understand which variables to expect. This way it's not required to initialize all possible taggers in advance. And it seriously simplifies testing.
  • Taggers are created one by one giving higher priority to the ones defined in components.

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #7867 (42f8b05) into main (290280e) will decrease coverage by 3.70%.
The diff coverage is 53.94%.

❗ Current head 42f8b05 differs from pull request most recent head 61309f9. Consider uploading reports for the commit 61309f9 to get more accurate results

@@            Coverage Diff             @@
##             main    #7867      +/-   ##
==========================================
- Coverage   70.48%   66.77%   -3.71%     
==========================================
  Files         515      594      +79     
  Lines       23150    28754    +5604     
==========================================
+ Hits        16317    19201    +2884     
- Misses       5776     8141    +2365     
- Partials     1057     1412     +355     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 367 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this! I have created #7933 to track updating the Skaffold documentation to also include the new INPUT_DIGEST field

@aaron-prindle aaron-prindle merged commit e9e6a02 into GoogleContainerTools:main Oct 11, 2022
@mikekamornikov mikekamornikov deleted the issue-7865 branch October 12, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

customTemplate tagger doesn't have any alias to inputDigest tagger
2 participants