Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): update examples to Spring Boot 2.7.4 and SnakeYAML 1.32 #7895

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

briandealwis
Copy link
Member

  • Update examples using Spring Boot to use 2.7.4 to fix numerous critical CVEs
  • Further pin SnakeYAML to 1.32 to address two recent CVEs
  • Reformatted pom.xml to use Google-style 2-space indentation for consistency

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Sep 27, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #7895 (a3610fb) into main (290280e) will decrease coverage by 3.81%.
The diff coverage is 53.94%.

@@            Coverage Diff             @@
##             main    #7895      +/-   ##
==========================================
- Coverage   70.48%   66.67%   -3.82%     
==========================================
  Files         515      593      +78     
  Lines       23150    28698    +5548     
==========================================
+ Hits        16317    19133    +2816     
- Misses       5776     8159    +2383     
- Partials     1057     1406     +349     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 365 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@briandealwis briandealwis changed the title Update examples to Spring Boot 2.7.4 and SnakeYAML 1.32 chore(examples): update examples to Spring Boot 2.7.4 and SnakeYAML 1.32 Sep 27, 2022
- Update examples using Spring Boot to use 2.7.4 to fix numerous
  critical CVEs
- Further pin SnakeYAML to 1.32 to address two recent CVEs
- Reformatted pom.xml to use Google-style 2-space indentation for
  consistency
@briandealwis
Copy link
Member Author

I can't see how these Kokoro failures can be tied back to this PR.

@aaron-prindle
Copy link
Contributor

These Kokoro failures are not related to this PR, they are a recently introduced failure related to mulit-platform integration test additions, more context here:
#7661 (comment)

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaron-prindle aaron-prindle merged commit d0f3822 into GoogleContainerTools:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants