Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use cmp.Diff to check for differences #7896

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

briandealwis
Copy link
Member

@briandealwis briandealwis commented Sep 27, 2022

Produce more readable test failures by using cmp.Diff.

time="2022-09-27T19:29:55Z" level=info msg="Pods marked as ready: map[module1:true module2:true]" subtask=-1 task=DevLoop
    build_test.go:257: Platforms differ (-got,+want):
          []v1.Platform(Inverse(cmpopts.SortSlices, []v1.Platform{
        - 	{Architecture: "amd64", OS: "linux"},
          	{Architecture: "arm64", OS: "linux"},
          }))

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #7896 (501bac1) into main (290280e) will decrease coverage by 3.82%.
The diff coverage is 53.94%.

@@            Coverage Diff             @@
##             main    #7896      +/-   ##
==========================================
- Coverage   70.48%   66.65%   -3.83%     
==========================================
  Files         515      593      +78     
  Lines       23150    28698    +5548     
==========================================
+ Hits        16317    19130    +2813     
- Misses       5776     8160    +2384     
- Partials     1057     1408     +351     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 365 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@briandealwis briandealwis marked this pull request as ready for review September 27, 2022 19:56
@briandealwis briandealwis merged commit 52f68bb into GoogleContainerTools:main Sep 28, 2022
@briandealwis briandealwis deleted the cmpdiff branch September 28, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants