Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change survey prompt frequency #7912

Conversation

ericzzzzzzz
Copy link
Contributor

@ericzzzzzzz ericzzzzzzz commented Oct 4, 2022

Fixes: #7908
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description

  • change survey prompt frequency from 10 days to 5 days (I'm a little bit confused, why we take 5 days as a week?)

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #7912 (8417156) into main (290280e) will decrease coverage by 3.71%.
The diff coverage is 53.94%.

@@            Coverage Diff             @@
##             main    #7912      +/-   ##
==========================================
- Coverage   70.48%   66.77%   -3.72%     
==========================================
  Files         515      593      +78     
  Lines       23150    28703    +5553     
==========================================
+ Hits        16317    19165    +2848     
- Misses       5776     8131    +2355     
- Partials     1057     1407     +350     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 365 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label Oct 5, 2022
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Oct 5, 2022
…kaffold-survey-to-be-presented-1-weekly-cadence
@tejal29
Copy link
Member

tejal29 commented Oct 6, 2022

  • change survey prompt frequency from 10 days to 5 days (I'm a little bit confused, why we take 5 days as a week?)

I think it's the definition of week ("working") on internal docs.

@tejal29 tejal29 merged commit 34b203d into GoogleContainerTools:main Oct 6, 2022
OladapoAjala pushed a commit to OladapoAjala/skaffold that referenced this pull request Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CSAT skaffold survey to be presented ~1 weekly cadence (vs 2 week cadence)
3 participants