Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add version menu label #7917

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

maggieneterval
Copy link
Contributor

Related: #7910

Description

Adds a version menu label of "Versions" to the versions dropdown on the v2 docs site. (This is the same versions label used by https://kubernetes.io/).

User facing changes

Previously, the versions dropdown was an unlabelled chevron and had low discoverability. Now, the versions dropdown is labeled and easily discoverable.

Before:

55LDLpFYyvhLo6a

After:

6oKBSqieU6QL5MB

Follow-up Work

Add informational banners to v1 and v2 docs sites. See #7910 for details.

@maggieneterval
Copy link
Contributor Author

@aaron-prindle PTAL. Thank you!

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #7917 (d6ebd87) into main (290280e) will decrease coverage by 3.73%.
The diff coverage is 53.94%.

@@            Coverage Diff             @@
##             main    #7917      +/-   ##
==========================================
- Coverage   70.48%   66.75%   -3.74%     
==========================================
  Files         515      593      +78     
  Lines       23150    28703    +5553     
==========================================
+ Hits        16317    19160    +2843     
- Misses       5776     8133    +2357     
- Partials     1057     1410     +353     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 364 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This looks way better now, thanks @maggieneterval!

@tejal29
Copy link
Member

tejal29 commented Oct 6, 2022

the signing bot is acting weird here.

@tejal29 tejal29 merged commit 7b0f58c into GoogleContainerTools:main Oct 7, 2022
OladapoAjala pushed a commit to OladapoAjala/skaffold that referenced this pull request Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants