Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow init without render and deploy #7936

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

gsquared94
Copy link
Collaborator

@gsquared94 gsquared94 commented Oct 11, 2022

Fixes: #7934
Specifying --skip-deploy should skip creating both render and deploy stanzas in the skaffold.yaml file

@gsquared94 gsquared94 added the 2.0.0 Issues related to the 2.0.0 release label Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #7936 (9f79856) into main (290280e) will decrease coverage by 3.62%.
The diff coverage is 53.94%.

@@            Coverage Diff             @@
##             main    #7936      +/-   ##
==========================================
- Coverage   70.48%   66.86%   -3.63%     
==========================================
  Files         515      594      +79     
  Lines       23150    28768    +5618     
==========================================
+ Hits        16317    19235    +2918     
- Misses       5776     8122    +2346     
- Partials     1057     1411     +354     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 367 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gsquared94 gsquared94 enabled auto-merge (squash) October 11, 2022 23:37
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gsquared94 gsquared94 merged commit fb4ba5f into GoogleContainerTools:main Oct 11, 2022
OladapoAjala pushed a commit to OladapoAjala/skaffold that referenced this pull request Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0.0 Issues related to the 2.0.0 release size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skaffold v2 skaffold init command failing
2 participants