Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skaffold v2] fix: Cloud Code log viewer shows render stage correctly #7937

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

gsquared94
Copy link
Collaborator

Fixes: #7930
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description

For Cloud Code VSCode, I've submitted the fix in the plugin repo directly. Shows correct output in their Nightly build:
image

For Cloud Code IntelliJ, this PR fixes the event description that shows up directly in the log view:
image

@gsquared94 gsquared94 changed the title fix: Cloud Code log viewer shows render stage correctly [skaffold v2] fix: Cloud Code log viewer shows render stage correctly Oct 12, 2022
@gsquared94 gsquared94 enabled auto-merge (squash) October 12, 2022 01:20
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #7937 (f0652d1) into main (290280e) will decrease coverage by 3.63%.
The diff coverage is 53.94%.

@@            Coverage Diff             @@
##             main    #7937      +/-   ##
==========================================
- Coverage   70.48%   66.85%   -3.64%     
==========================================
  Files         515      594      +79     
  Lines       23150    28768    +5618     
==========================================
+ Hits        16317    19232    +2915     
- Misses       5776     8123    +2347     
- Partials     1057     1413     +356     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 367 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skaffold v2 not showing Render logs in Cloud Code
2 participants