Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add generic util.Ptr function #7961

Merged

Conversation

gsquared94
Copy link
Collaborator

Replace util.StringPtr, util.IntPtr and util.BoolPtr with a generic util.Ptr 🥹

func Ptr[T any](t T) *T {
	o := t
	return &o
}

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #7961 (9323b81) into main (290280e) will decrease coverage by 3.66%.
The diff coverage is 54.09%.

@@            Coverage Diff             @@
##             main    #7961      +/-   ##
==========================================
- Coverage   70.48%   66.82%   -3.67%     
==========================================
  Files         515      594      +79     
  Lines       23150    28794    +5644     
==========================================
+ Hits        16317    19241    +2924     
- Misses       5776     8138    +2362     
- Partials     1057     1415     +358     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/app/exitcode.go 100.00% <ø> (+6.66%) ⬆️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
... and 389 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's glorius! 🥇

@gsquared94 gsquared94 merged commit 4c62602 into GoogleContainerTools:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants