Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add a copy of the buildpacks node tutorial without a skaffold.yaml #7968

Merged

Conversation

maggieneterval
Copy link
Contributor

Description

Creates a copy of the buildpacks node tutorial without a skaffold.yaml, so that it can be used in a tutorial that has users run skaffold init to generate the skaffold.yaml.

@aaron-prindle LMK what you think!

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #7968 (4809df9) into main (290280e) will decrease coverage by 3.84%.
The diff coverage is 54.09%.

@@            Coverage Diff             @@
##             main    #7968      +/-   ##
==========================================
- Coverage   70.48%   66.63%   -3.85%     
==========================================
  Files         515      596      +81     
  Lines       23150    28889    +5739     
==========================================
+ Hits        16317    19251    +2934     
- Misses       5776     8207    +2431     
- Partials     1057     1431     +374     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/app/exitcode.go 100.00% <ø> (+6.66%) ⬆️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
... and 388 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think if you can rebase and resubmit this, we can get all the tests passing and then merge

@aaron-prindle
Copy link
Contributor

I think there is one small error from our CI/CD:

Every code sample that is in ./examples should also be in ./integration/examples
The following are in examples but not in integration/examples:
buildpacks-node-tutorial
FAILED hack/check-samples.sh

Can you copy this sample to integration/examples?

@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 25, 2022
@aaron-prindle aaron-prindle merged commit 688d0ba into GoogleContainerTools:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants