Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add anchors to yaml paths #8541

Merged
merged 3 commits into from
Aug 4, 2023

Conversation

renzodavid9
Copy link
Contributor

@renzodavid9 renzodavid9 commented Mar 10, 2023

Description

This PR is to help improve the usability of the skaffold.yaml reference page extending the behaviour of the current tooltip: now the users will be able to go from an specific inner element in the skaffold.yaml reference page, to the parents of that element using the path that appears in the tooltip.

Staging link: http://35.222.98.113:1313/docs/references/yaml/

@renzodavid9 renzodavid9 added !! do-not-merge !! docs-modifications-v2 runs the docs v2 preview service on the given PR labels Mar 10, 2023
@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

@container-tools-bot container-tools-bot removed the docs-modifications-v2 runs the docs v2 preview service on the given PR label Mar 10, 2023
@renzodavid9 renzodavid9 added the docs-modifications-v2 runs the docs v2 preview service on the given PR label Mar 10, 2023
@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

@container-tools-bot container-tools-bot removed the docs-modifications-v2 runs the docs v2 preview service on the given PR label Mar 10, 2023
@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

@container-tools-bot
Copy link

Error creating deployment docs-controller-deployment-8541, please visit https://storage.googleapis.com/webhook-logs/logs-8541-1678469712782155680 to view logs.

@container-tools-bot
Copy link

Error creating deployment, please see controller logs for details.

@renzodavid9 renzodavid9 force-pushed the yaml-path-links branch 2 times, most recently from 9036ce4 to 4fcc3ff Compare March 10, 2023 17:48
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #8541 (eda8193) into main (290280e) will decrease coverage by 6.82%.
Report is 988 commits behind head on main.
The diff coverage is 49.80%.

@@            Coverage Diff             @@
##             main    #8541      +/-   ##
==========================================
- Coverage   70.48%   63.67%   -6.82%     
==========================================
  Files         515      624     +109     
  Lines       23150    31941    +8791     
==========================================
+ Hits        16317    20337    +4020     
- Misses       5776    10078    +4302     
- Partials     1057     1526     +469     
Files Changed Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 415 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle added the docs-modifications-v2 runs the docs v2 preview service on the given PR label Mar 10, 2023
@container-tools-bot
Copy link

Please visit http://34.66.12.62:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications-v2 runs the docs v2 preview service on the given PR label Mar 10, 2023
@aaron-prindle
Copy link
Contributor

From mtg - maybe we can add a note/some-text at the top stating that you can hover to get the schema path for the current item and click on the hover path as well to go to specific elements

@renzodavid9
Copy link
Contributor Author

Ignore, making triage party happy

@renzodavid9 renzodavid9 added the docs-modifications-v2 runs the docs v2 preview service on the given PR label May 5, 2023
@container-tools-bot
Copy link

Please visit http://34.27.231.184:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications-v2 runs the docs v2 preview service on the given PR label May 5, 2023
@renzodavid9 renzodavid9 added the docs-modifications-v2 runs the docs v2 preview service on the given PR label May 19, 2023
@container-tools-bot
Copy link

Please visit http://35.222.98.113:1313 to view changes to the docs.

@container-tools-bot container-tools-bot removed the docs-modifications-v2 runs the docs v2 preview service on the given PR label May 19, 2023
@renzodavid9 renzodavid9 marked this pull request as ready for review May 19, 2023 21:25
@renzodavid9
Copy link
Contributor Author

We have some tests related with buildpacks failing:

...
        Building [skaffold-debug-nodejs]...
        Build [skaffold-debug-nodejs] was canceled
    panic.go:522: failed to fetch builder image 'gcr.io/buildpacks/builder:v1': No such image: gcr.io/buildpacks/builder:latest
    --- FAIL: TestDebug/buildpacks (17.32s)

@renzodavid9 renzodavid9 added the kokoro:force-run forces a kokoro re-run on a PR label May 24, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label May 24, 2023
@renzodavid9 renzodavid9 added the docs-modifications-v2 runs the docs v2 preview service on the given PR label Jun 29, 2023
@container-tools-bot
Copy link

Error creating deployment docs-controller-deployment-8541, please visit https://storage.googleapis.com/webhook-logs/logs-8541-1688055183161056773 to view logs.

@container-tools-bot container-tools-bot removed the docs-modifications-v2 runs the docs v2 preview service on the given PR label Jun 29, 2023
@renzodavid9 renzodavid9 merged commit 0da33e6 into GoogleContainerTools:main Aug 4, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants