-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: firelog exporter #8555
Merged
gsquared94
merged 12 commits into
GoogleContainerTools:main
from
ericzzzzzzz:firelog-exporter
Mar 24, 2023
Merged
chore: firelog exporter #8555
gsquared94
merged 12 commits into
GoogleContainerTools:main
from
ericzzzzzzz:firelog-exporter
Mar 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8555 +/- ##
==========================================
- Coverage 70.48% 64.24% -6.24%
==========================================
Files 515 609 +94
Lines 23150 30559 +7409
==========================================
+ Hits 16317 19633 +3316
- Misses 5776 9455 +3679
- Partials 1057 1471 +414
... and 388 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gsquared94
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ericzzzzzzz
added a commit
to ericzzzzzzz/skaffold
that referenced
this pull request
Mar 28, 2023
This reverts commit 70ed898.
This was referenced Mar 28, 2023
aaron-prindle
pushed a commit
that referenced
this pull request
Mar 28, 2023
Merged
ericzzzzzzz
added a commit
to ericzzzzzzz/skaffold
that referenced
this pull request
Mar 28, 2023
This reverts commit 710963c.
aaron-prindle
pushed a commit
that referenced
this pull request
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8432
Description
Future work
Test Plan
skaffold dev -vtrace
in examples/getting-started projectmetrics uploading complete in xxxx seconds
from the log