Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: firelog exporter #8555

Merged
merged 12 commits into from
Mar 24, 2023

Conversation

ericzzzzzzz
Copy link
Contributor

@ericzzzzzzz ericzzzzzzz commented Mar 16, 2023

Fixes: #8432

Description

  • This pr switches the open telemetry exporter from cloudMonitorExport to fireLogExporter , so we can push skaffold metrics to firelog one-platform
  • Adds ci-platform data into metrics
  • By default, the firelog apiKey is empty, so non-exporter is enabled at the moment.

Future work

  • The current implementation is sending metrics data sequentially, we may send metrics data in parallel.
  • We might also need to add a flag or global config variable to toggle enabling/disabling exporter
  • More metrics data may be added.

Test Plan

  • add apiKey and build the binary, the run skaffold dev -vtrace in examples/getting-started project
  • Should be able to see metrics uploading complete in xxxx seconds from the log

@ericzzzzzzz ericzzzzzzz changed the title chore: firelog exporter chore: firelog exporter [no-ci] Mar 16, 2023
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #8555 (ba310e3) into main (290280e) will decrease coverage by 6.24%.
The diff coverage is 54.74%.

@@            Coverage Diff             @@
##             main    #8555      +/-   ##
==========================================
- Coverage   70.48%   64.24%   -6.24%     
==========================================
  Files         515      609      +94     
  Lines       23150    30559    +7409     
==========================================
+ Hits        16317    19633    +3316     
- Misses       5776     9455    +3679     
- Partials     1057     1471     +414     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/diagnose.go 62.22% <0.00%> (-2.65%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
... and 38 more

... and 388 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review March 20, 2023 18:05
@ericzzzzzzz ericzzzzzzz changed the title chore: firelog exporter [no-ci] chore: firelog exporter Mar 21, 2023
Copy link
Collaborator

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gsquared94 gsquared94 merged commit 70ed898 into GoogleContainerTools:main Mar 24, 2023
ericzzzzzzz added a commit to ericzzzzzzz/skaffold that referenced this pull request Mar 28, 2023
aaron-prindle pushed a commit that referenced this pull request Mar 28, 2023
@aaron-prindle aaron-prindle mentioned this pull request Mar 28, 2023
ericzzzzzzz added a commit to ericzzzzzzz/skaffold that referenced this pull request Mar 28, 2023
aaron-prindle pushed a commit that referenced this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Firelog exporter to export metrics
2 participants