Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove printing errors from IsKubernetesManifest and change doApply to use ParseKubernetesObjects to retrieve the error #8559

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

renzodavid9
Copy link
Contributor

@renzodavid9 renzodavid9 commented Mar 17, 2023

Fixes: #8547

Description
skaffold init uses the IsKubernetesManifest to filter the files found in the folder, for each file that is not a K8s manifest skaffold is showing an error, even when this does not represent an error for this command. This PR removes the log from the IsKubernetesManifest function, and change doApply to use ParseKubernetesObjects instead where the error can be returned.

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #8559 (8f1a2b6) into main (290280e) will decrease coverage by 6.29%.
The diff coverage is 54.03%.

@@            Coverage Diff             @@
##             main    #8559      +/-   ##
==========================================
- Coverage   70.48%   64.19%   -6.29%     
==========================================
  Files         515      610      +95     
  Lines       23150    30593    +7443     
==========================================
+ Hits        16317    19640    +3323     
- Misses       5776     9480    +3704     
- Partials     1057     1473     +416     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 38 more

... and 389 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 changed the title fix: change IsKubernetesManifest error print to debug to not show many errors during skaffold init fix: remove printing errors from IsKubernetesManifest and change doApply to use ParseKubernetesObjects to retrieve the error Mar 27, 2023
@renzodavid9 renzodavid9 marked this pull request as ready for review March 27, 2023 17:56
…ply to not use this method but ParseKubernetesObjects to retrieve the error
@aaron-prindle aaron-prindle merged commit fbb4b99 into GoogleContainerTools:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants