Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: standarize renders to inject namespace only if --namespace or render specific config is set #8561

Merged
merged 3 commits into from
Apr 5, 2023

Conversation

renzodavid9
Copy link
Contributor

@renzodavid9 renzodavid9 commented Mar 17, 2023

Fixes: #8318

Description
This PR will make the existing renderers to only inject a metadata.namespace field if a --namespace flag is set or if the render itself is configured for that.

Pending
Validate helm behavior

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #8561 (eaf767d) into main (290280e) will decrease coverage by 6.25%.
The diff coverage is 54.47%.

@@            Coverage Diff             @@
##             main    #8561      +/-   ##
==========================================
- Coverage   70.48%   64.24%   -6.25%     
==========================================
  Files         515      613      +98     
  Lines       23150    30711    +7561     
==========================================
+ Hits        16317    19729    +3412     
- Misses       5776     9504    +3728     
- Partials     1057     1478     +421     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 39 more

... and 393 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaron-prindle aaron-prindle merged commit cbac94f into GoogleContainerTools:main Apr 5, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants