Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom actions interfaces and actions runner implementation #8563

Merged
merged 9 commits into from
Apr 11, 2023

Conversation

renzodavid9
Copy link
Contributor

@renzodavid9 renzodavid9 commented Mar 21, 2023

Fixes: #8522

Description
This PR adds the set of interfaces and types used by the Custom Actions, and implements the ActionsRunner in charge of executing a custom action according to the configuration.

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #8563 (46f45c6) into main (290280e) will decrease coverage by 6.39%.
The diff coverage is 54.47%.

@@            Coverage Diff             @@
##             main    #8563      +/-   ##
==========================================
- Coverage   70.48%   64.09%   -6.39%     
==========================================
  Files         515      617     +102     
  Lines       23150    30904    +7754     
==========================================
+ Hits        16317    19808    +3491     
- Misses       5776     9608    +3832     
- Partials     1057     1488     +431     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 39 more

... and 396 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 force-pushed the ca-feature-8522 branch 2 times, most recently from f212e13 to f0ef507 Compare March 27, 2023 14:18
@renzodavid9 renzodavid9 marked this pull request as ready for review March 27, 2023 14:58
@renzodavid9 renzodavid9 requested review from a team, maggieneterval, aaron-prindle, ericzzzzzzz and gsquared94 and removed request for a team March 27, 2023 14:58
@renzodavid9 renzodavid9 added the kokoro:force-run forces a kokoro re-run on a PR label Mar 27, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Mar 27, 2023
@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label Mar 27, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Mar 27, 2023
@renzodavid9 renzodavid9 force-pushed the ca-feature-8522 branch 2 times, most recently from d376962 to cf2873b Compare March 28, 2023 16:49
Copy link
Collaborator

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@renzodavid9 renzodavid9 merged commit 0e661f1 into GoogleContainerTools:main Apr 11, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Custom Actions] Create actions runner to manage the actions execution
4 participants