Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minor edits to Cloud Build docs #8571

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

maggieneterval
Copy link
Contributor

@maggieneterval maggieneterval commented Mar 22, 2023

Related: #8383

Description

Minor edits to the Cloud Build page:

  • After introducing the product as "Google Cloud Build" for clarity, consistently name it as "Cloud Build" for consistency with GCP docs.
  • Use a consistent tense.
  • Prefer bulleted lists to comma-separated items.
  • Update "Faster builds" section wording for clarity.

Next steps

  • Add link to Cloud Build tutorial, when published.

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #8571 (6314932) into main (290280e) will decrease coverage by 6.27%.
The diff coverage is 53.80%.

@@            Coverage Diff             @@
##             main    #8571      +/-   ##
==========================================
- Coverage   70.48%   64.21%   -6.27%     
==========================================
  Files         515      613      +98     
  Lines       23150    30689    +7539     
==========================================
+ Hits        16317    19708    +3391     
- Misses       5776     9503    +3727     
- Partials     1057     1478     +421     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/flags.go 93.00% <ø> (+2.18%) ⬆️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
... and 38 more

... and 391 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label Mar 23, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Mar 23, 2023
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Left one comment related to changing the wording as you mentioned a potential change there (adding some text to state explicity that Cloud Build is doing the builds in parallel)

@aaron-prindle aaron-prindle merged commit dcdf7c1 into GoogleContainerTools:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants