Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade docker and make integration-in-docker to use docker dependencies from pr #8596

Merged
merged 3 commits into from
Mar 30, 2023
Merged

chore: upgrade docker and make integration-in-docker to use docker dependencies from pr #8596

merged 3 commits into from
Mar 30, 2023

Conversation

ericzzzzzzz
Copy link
Contributor

@ericzzzzzzz ericzzzzzzz commented Mar 28, 2023 •
edited

Fixes: #8578
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description

  • This pr upgrades docker bin in skaffold image as the old one is not working when running some kpt images.
  • Adds buildx into skaffold image, as after 23.0.0 the buildx is not bundled with docker directly, we need to add it separately
  • Also, change the kokoro presubmit pipeline to pick up changes in the pr while still taking advantages of the docker deps
    cache
    User facing changes (remove if N/A)

Follow-up Work (remove if N/A)

@ericzzzzzzz ericzzzzzzz force-pushed the upgrade-docker-in-skaffold-image branch from a78d09c to a668375 Compare March 28, 2023 17:41
@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review March 28, 2023 18:34
@ericzzzzzzz ericzzzzzzz changed the title chore: upgrade docker and make test-in-docker to use pr dependency chore: upgrade docker and make test-in-docker to use docker dependencies from pr Mar 28, 2023
@aaron-prindle
Copy link
Contributor

aaron-prindle commented Mar 28, 2023 •
edited

Going to wait on this PR until v2.3.0 is released due to kokoro breakage related to a similar change, will LGTM and merge after

@ericzzzzzzz ericzzzzzzz changed the title chore: upgrade docker and make test-in-docker to use docker dependencies from pr chore: upgrade docker and make integration-in-docker to use docker dependencies from pr Mar 28, 2023
aaron-prindle
aaron-prindle approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaron-prindle aaron-prindle merged commit 109fe4e into GoogleContainerTools:main Mar 30, 2023
@aaron-prindle aaron-prindle mentioned this pull request Apr 11, 2023
Closed
aaron-prindle pushed a commit that referenced this pull request May 15, 2023
@ericzzzzzzz @aaron-prindle
chore: upgrade docker and make integration-in-docker to use docker de…
9dfd49b 
…pendencies from pr (#8596)

* chore: upgrade docker and make test-in-docker to use pr dependency

* chore: fix docker build commandE

* chore: fix docker build command

(cherry picked from commit 109fe4e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron-prindle aaron-prindle aaron-prindle approved these changes

@renzodavid9 renzodavid9 Awaiting requested review from renzodavid9

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
2 participants
@ericzzzzzzz @aaron-prindle