Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issue where verify would panic if a jobManifestPath with no spec.template.spec.metadata.labels existed #8618

Merged

Conversation

aaron-prindle
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #8618 (013786a) into main (290280e) will decrease coverage by 6.24%.
The diff coverage is 54.74%.

@@            Coverage Diff             @@
##             main    #8618      +/-   ##
==========================================
- Coverage   70.48%   64.25%   -6.24%     
==========================================
  Files         515      613      +98     
  Lines       23150    30700    +7550     
==========================================
+ Hits        16317    19725    +3408     
- Misses       5776     9496    +3720     
- Partials     1057     1479     +422     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 39 more

... and 393 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle merged commit 16cc5c0 into GoogleContainerTools:main Mar 30, 2023
@aaron-prindle aaron-prindle added this to the v2.3.1 milestone Apr 4, 2023
aaron-prindle added a commit that referenced this pull request May 15, 2023
…spec.template.spec.metadata.labels existed (#8618)

(cherry picked from commit 16cc5c0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants