fix: deploy to multiple namespaces #8623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8623 +/- ##
==========================================
- Coverage 70.48% 64.23% -6.25%
==========================================
Files 515 613 +98
Lines 23150 30708 +7558
==========================================
+ Hits 16317 19725 +3408
- Misses 5776 9503 +3727
- Partials 1057 1480 +423
... and 392 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| ARG SKAFFOLD_GO_GCFLAGS | ||
| RUN go build -gcflags="${SKAFFOLD_GO_GCFLAGS}" -trimpath -o /app main.go | ||
|
|
||
| FROM alpine:3.10 |
There was a problem hiding this comment.
nit: Alpine 3.10 is from ~2019, might make sense to use a more recent alpine version eg: 3.15+
| ns, client := SetupNamespace(t.T) | ||
| ns2, _ := SetupNamespace(t.T) | ||
|
|
||
| _, _, fErr := replaceInFile("namespace1", ns.Name, fmt.Sprintf("%s/skaffold.yaml", "testdata/helm-multi-namespaces")) |
There was a problem hiding this comment.
nit: might make sense to use a separate constant for the test data directory path instead of repeating "testdata/helm-multi-namespaces". Might make it easier to update the path if necessary in the future.
aaron-prindle
pushed a commit
that referenced
this pull request
May 15, 2023
(cherry picked from commit 3b5320c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: b/266719200
Description
If the rendered manifest has multiple namespaces, retry
kubectl createdry-runcommand without a namespace flag.Testing instruction
See the added integration test.