Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add the LOG_STREAM_RUN_GCLOUD_NOT_FOUND code in the proto file #8644

Conversation

renzodavid9
Copy link
Contributor

@renzodavid9 renzodavid9 commented Apr 5, 2023

Related : #8012

Description
In #8012 we added a new error code directly to the skaffold.pb.go and nums.pb.go files, without updating the enums.proto file; skaffold.pb.go and nums.pb.go are autogenerated when running ./hack/generate-proto.sh, so, without the changes in the enums.proto the go files are out of sync.

This PR adds the code to the enums.proto file, and commits the result from running ./hack/generate-proto.sh. The error name had change too.

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #8644 (351f5dc) into main (290280e) will decrease coverage by 6.34%.
The diff coverage is 54.47%.

@@            Coverage Diff             @@
##             main    #8644      +/-   ##
==========================================
- Coverage   70.48%   64.14%   -6.34%     
==========================================
  Files         515      615     +100     
  Lines       23150    30790    +7640     
==========================================
+ Hits        16317    19750    +3433     
- Misses       5776     9557    +3781     
- Partials     1057     1483     +426     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 39 more

... and 395 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 merged commit f2f8a21 into GoogleContainerTools:main Apr 5, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants