feat: add template support for chartPath
#8645
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8626
Description
The
skaffold render
command doesn't support templating onchartPath
field at the moment.This PR attempts to enable templating on
chartPath
field.I have added a basic unit test, please review it and let me know if I need to add/adjust something there.
User facing changes
We would get the following error when there is a template/environment variable
With this PR, template/environment variables should render successfully.