Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better Job support by allowing skaffold to re-apply Jobs by removing child pod label transform #8659

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

aaron-prindle
Copy link
Contributor

fixes #8544

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #8659 (00c281f) into main (290280e) will decrease coverage by 6.35%.
The diff coverage is 54.47%.

@@            Coverage Diff             @@
##             main    #8659      +/-   ##
==========================================
- Coverage   70.48%   64.13%   -6.35%     
==========================================
  Files         515      615     +100     
  Lines       23150    30816    +7666     
==========================================
+ Hits        16317    19764    +3447     
- Misses       5776     9569    +3793     
- Partials     1057     1483     +426     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 39 more

... and 395 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle merged commit d39e853 into GoogleContainerTools:main Apr 11, 2023
15 checks passed
aaron-prindle added a commit that referenced this pull request May 15, 2023
…oving child pod label transform (#8659)

(cherry picked from commit d39e853)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot reapply Job type resource using skaffold apply
2 participants