Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new docker exec env and task #8662

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

renzodavid9
Copy link
Contributor

Fixes: #8520

Description
This PR adds the implementation of the needed exec environment and task to run local (with Docker) custom actions.

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #8662 (04487f9) into main (290280e) will decrease coverage by 6.44%.
The diff coverage is 54.02%.

@@            Coverage Diff             @@
##             main    #8662      +/-   ##
==========================================
- Coverage   70.48%   64.04%   -6.44%     
==========================================
  Files         515      621     +106     
  Lines       23150    31132    +7982     
==========================================
+ Hits        16317    19940    +3623     
- Misses       5776     9694    +3918     
- Partials     1057     1498     +441     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 400 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 marked this pull request as ready for review April 11, 2023 15:53
@renzodavid9 renzodavid9 merged commit e6e88ed into GoogleContainerTools:main Apr 17, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Custom Actions] Create local actions
2 participants