Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update helm renderer docs to use correct manifests vs deploy syntax #8667

Merged

Conversation

aaron-prindle
Copy link
Contributor

fixes #8666

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #8667 (bbc40d0) into main (290280e) will decrease coverage by 6.38%.
The diff coverage is 54.02%.

@@            Coverage Diff             @@
##             main    #8667      +/-   ##
==========================================
- Coverage   70.48%   64.10%   -6.38%     
==========================================
  Files         515      619     +104     
  Lines       23150    30946    +7796     
==========================================
+ Hits        16317    19838    +3521     
- Misses       5776     9618    +3842     
- Partials     1057     1490     +433     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 398 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle merged commit ba73ccb into GoogleContainerTools:main Apr 20, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm renderer docs have samples for helm deployer (deploy vs manifests schema config)
2 participants