Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom actions execution modes to inspect executionModes list #8697

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

renzodavid9
Copy link
Contributor

Related: #8609

Description
This PR extend the inspect executionModes list command to include the information detected in the customActions stanza.

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #8697 (70d3630) into main (290280e) will decrease coverage by 5.99%.
The diff coverage is 54.27%.

@@            Coverage Diff             @@
##             main    #8697      +/-   ##
==========================================
- Coverage   70.48%   64.50%   -5.99%     
==========================================
  Files         515      615     +100     
  Lines       23150    31003    +7853     
==========================================
+ Hits        16317    19997    +3680     
- Misses       5776     9507    +3731     
- Partials     1057     1499     +442     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 39 more

... and 406 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaron-prindle aaron-prindle merged commit 8ee1f85 into GoogleContainerTools:main Apr 25, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants