chore: Update ko builder to use ko v0.13.0 #8699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main change in ko v0.13.0 that is relevant to current Skaffold features it the change in default base image from `gcr.io/distroless/static:nonroot` to `cgr.dev/chainguard/static:latest`. Some of the ko builder examples overrides the default base image with `gcr.io/distroless/static-debian11:nonroot`, to assist users who run Skaffold in Google Cloud VPC networks with limited or no internet connectivity. These users can access Google's distroless images in Container Registry and Artifact Registry via Private Google Access. This change also changes the ko builder maturity to Beta :-)
halvards
commented
Apr 21, 2023
| @@ -88,7 +88,7 @@ | |||
| "debug": "x", | |||
| "area": "Build", | |||
| "feature": "ko builder", | |||
| "maturity": "alpha", | |||
| "maturity": "beta", | |||
There was a problem hiding this comment.
I hope this is ok :-D. Please let me know if it's not, I'd be happy to revert it.
halvards
commented
Apr 21, 2023
| profiles: | ||
| - name: gcb | ||
| build: | ||
| googleCloudBuild: | ||
| koImage: us-central1-docker.pkg.dev/k8s-skaffold/testing/skaffold:v1.37.2-lts | ||
| koImage: us-central1-docker.pkg.dev/k8s-skaffold/testing/skaffold:v1.37.2 |
There was a problem hiding this comment.
The previous tag didn't exist in the repository.
halvards
commented
Apr 21, 2023
| pushd $(mktemp -d) | ||
| curl -L https://github.com/google/ko/archive/v0.12.0.tar.gz | tar --strip-components 1 -zx | ||
| go build -o $(go env GOPATH)/bin/ko . | ||
| pushd "$(mktemp -d)" |
There was a problem hiding this comment.
Adding quotes here to fix shellcheck errors.
halvards
commented
Apr 21, 2023
| @@ -58,7 +58,7 @@ substitutions: | |||
| _GKE_CLUSTER_PROJECT_ID: $PROJECT_ID | |||
| _GKE_CLUSTER_ZONE: us-central1-f | |||
| _IMAGE_REPO: gcr.io/${PROJECT_ID} | |||
| _GCLOUD_IMAGE: us-central1-docker.pkg.dev/k8s-skaffold/testing/skaffold | |||
| _SKAFFOLD_IMAGE: us-central1-docker.pkg.dev/k8s-skaffold/testing/skaffold | |||
| _GCLOUD_IMAGE: gcr.io/k8s-skaffold/skaffold | |||
There was a problem hiding this comment.
The current images don't exist afaict.
Codecov Report
@@ Coverage Diff @@
## main #8699 +/- ##
==========================================
- Coverage 70.48% 64.49% -6.00%
==========================================
Files 515 616 +101
Lines 23150 30985 +7835
==========================================
+ Hits 16317 19983 +3666
- Misses 5776 9502 +3726
- Partials 1057 1500 +443
... and 406 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7851 and #8698
The main user-facing change in ko v0.13.0 that is relevant to current Skaffold features is the change in default base image from
gcr.io/distroless/static:nonroottocgr.dev/chainguard/static:latest.Some of the Skaffold ko builder examples overrides the default base image with
gcr.io/distroless/static-debian11:nonroot. This assists users who run Skaffold in Google Cloud VPC networks with limited or no internet connectivity. These users can access Google's distroless images in Container Registry and Artifact Registry via Private Google Access.This change also updates the ko builder maturity to Beta :-)