fix: new remove method in docker client to use in custom actions and don't get the error related with prune
#8710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d don't get the error related with prune
Codecov Report
@@ Coverage Diff @@
## main #8710 +/- ##
==========================================
- Coverage 70.48% 64.43% -6.05%
==========================================
Files 515 617 +102
Lines 23150 31177 +8027
==========================================
+ Hits 16317 20090 +3773
- Misses 5776 9583 +3807
- Partials 1057 1504 +447
... and 406 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -127,7 +127,8 @@ func (t Task) Cleanup(ctx context.Context, out io.Writer) error { | |||
| return nil | |||
| } | |||
|
|
|||
| if err := t.client.Delete(ctx, out, id); err != nil { | |||
| t.client.Stop(ctx, id, nil) | |||
There was a problem hiding this comment.
Should this also be used in verify and possibly the docker deployer as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to remove the warning message we get when running a custom action with more than one container, caused by a docker prune executed for each container.