Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change inspect executionMode list to list all actions exec mode per default #8719

Merged

Conversation

renzodavid9
Copy link
Contributor

Description
This PR changes the inspect executionMode list command to not receive any custom action name as parameter and to list all the custom actions execution modes per default. This change makes the command to have the same behaviour as inspect jobManifestPaths list.

@renzodavid9 renzodavid9 changed the title Ca execution mode change feat: change inspect executionMode list to list all actions exec mode per default Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #8719 (50240c3) into main (290280e) will decrease coverage by 6.04%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #8719      +/-   ##
==========================================
- Coverage   70.48%   64.45%   -6.04%     
==========================================
  Files         515      617     +102     
  Lines       23150    31162    +8012     
==========================================
+ Hits        16317    20084    +3767     
- Misses       5776     9575    +3799     
- Partials     1057     1503     +446     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 407 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 marked this pull request as ready for review April 28, 2023 15:03
Copy link
Contributor

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaron-prindle aaron-prindle merged commit 0367eba into GoogleContainerTools:main Apr 28, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants