Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable edge image scanning #8942

Merged

Conversation

ericzzzzzzz
Copy link
Contributor

  • As team discussed, we would like to disable edge image vulnerabilities scanning due to the scope is too large and proper scope has already been covered by lts images.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #8942 (0822c96) into main (290280e) will decrease coverage by 6.86%.
The diff coverage is 48.91%.

@@            Coverage Diff             @@
##             main    #8942      +/-   ##
==========================================
- Coverage   70.48%   63.62%   -6.86%     
==========================================
  Files         515      624     +109     
  Lines       23150    31925    +8775     
==========================================
+ Hits        16317    20312    +3995     
- Misses       5776    10086    +4310     
- Partials     1057     1527     +470     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 416 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz merged commit f738766 into GoogleContainerTools:main Jul 17, 2023
11 of 15 checks passed
@ericzzzzzzz
Copy link
Contributor Author

merged this as the change should not affect integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants