Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix typo in Cloud Run log tailing #8944

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

bskaplan
Copy link
Contributor

@bskaplan bskaplan commented Jul 13, 2023

Switch & to % so we properly rotate through all of the colors. This matches the behavior in

p.imageColors[imageName] = DefaultColorCodes[len(p.imageColors)%len(DefaultColorCodes)]

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #8944 (daea5dc) into main (290280e) will decrease coverage by 6.87%.
The diff coverage is 48.91%.

@@            Coverage Diff             @@
##             main    #8944      +/-   ##
==========================================
- Coverage   70.48%   63.62%   -6.87%     
==========================================
  Files         515      624     +109     
  Lines       23150    31925    +8775     
==========================================
+ Hits        16317    20311    +3994     
- Misses       5776    10087    +4311     
- Partials     1057     1527     +470     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 416 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz
Copy link
Contributor

the ci is broken, the change is very small and should not be blocked by broken ci tests.

@ericzzzzzzz ericzzzzzzz merged commit a740bb2 into GoogleContainerTools:main Jul 17, 2023
9 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants