Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configure minikube to a static version in github ci #8951

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

ericzzzzzzz
Copy link
Contributor

@ericzzzzzzz ericzzzzzzz commented Jul 17, 2023

Description

  • CI build was broken due to minikube unknown change on HEAD from main branch
  • We should use a release version minikube for our CI instead of the one built from HEAD
  • This PR changes minikube version on github ci

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #8951 (bf0bf0f) into main (290280e) will decrease coverage by 6.86%.
The diff coverage is 48.91%.

@@            Coverage Diff             @@
##             main    #8951      +/-   ##
==========================================
- Coverage   70.48%   63.62%   -6.86%     
==========================================
  Files         515      624     +109     
  Lines       23150    31925    +8775     
==========================================
+ Hits        16317    20312    +3995     
- Misses       5776    10086    +4310     
- Partials     1057     1527     +470     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 416 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz changed the title chore: .. chore: configure minikube to a static version in github ci Jul 17, 2023
@ericzzzzzzz ericzzzzzzz marked this pull request as ready for review July 17, 2023 18:19
Copy link
Contributor

@renzodavid9 renzodavid9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😎

@renzodavid9 renzodavid9 merged commit 27dea2e into GoogleContainerTools:main Jul 17, 2023
14 checks passed
plumpy pushed a commit to plumpy/skaffold that referenced this pull request Jul 18, 2023
…tainerTools#8951)

* chore: ..

* chore: make minikube version a variable

(cherry picked from commit 27dea2e)
plumpy added a commit that referenced this pull request Jul 18, 2023
…8954)

* chore: ..

* chore: make minikube version a variable

(cherry picked from commit 27dea2e)

Co-authored-by: ericzzzzzzz <102683393+ericzzzzzzz@users.noreply.github.com>
ericzzzzzzz added a commit to ericzzzzzzz/skaffold that referenced this pull request Aug 4, 2023
ericzzzzzzz added a commit to ericzzzzzzz/skaffold that referenced this pull request Aug 4, 2023
ericzzzzzzz added a commit that referenced this pull request Aug 4, 2023
* chore: remove latest tagging from relase process

* chore:  configure minikube to a static version in github ci  (#8951)

* chore: ..

* chore: make minikube version a variable
ericzzzzzzz added a commit that referenced this pull request Aug 4, 2023
* chore: remove latest tagging from relase process

* chore:  configure minikube to a static version in github ci  (#8951)

* chore: ..

* chore: make minikube version a variable
plumpy pushed a commit to plumpy/skaffold that referenced this pull request Aug 8, 2023
…erTools#8987)

* chore: remove latest tagging from relase process

* chore:  configure minikube to a static version in github ci  (GoogleContainerTools#8951)

* chore: ..

* chore: make minikube version a variable
plumpy pushed a commit to plumpy/skaffold that referenced this pull request Aug 8, 2023
…ools#8985)

* chore: remove latest tagging from relase process

* chore:  configure minikube to a static version in github ci  (GoogleContainerTools#8951)

* chore: ..

* chore: make minikube version a variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants