fix: verify hangs if event-logs-file does not exist (#7613) #8961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hm, looking into the permissions error. Weird that the file cannot be created in the directory that we have created. |
Darien-Lin
force-pushed
the
verify-hangs-with-event-logs
branch
from
2148144
to
506953d
Compare
|
changed to use 0700 instead of 0600 for the directory |
Codecov Report
@@ Coverage Diff @@
## main #8961 +/- ##
==========================================
- Coverage 70.48% 63.62% -6.86%
==========================================
Files 515 624 +109
Lines 23150 31932 +8782
==========================================
+ Hits 16317 20317 +4000
- Misses 5776 10086 +4310
- Partials 1057 1529 +472
... and 416 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ericzzzzzzz
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7613
Description
When running
skaffold verifywith rpc-port and --event-log-file, if the event-log-file references a path to a file where the directory doesn't exist, the command hangs indefinitely. The changes I am proposing ensure that the directories to event-log-file exists before attempting to create the file and dump the logs. The relevant unit tests are also adjusted with the assumption that the directory does not exist.In addition, SaveLastLog seems to follow the same issue, which is also fixed in this PR.
0700 is used since 'execute' permission is needed on the directories. Execute permissions on directory are so that files can be accessed in those nested directories.