Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #9006 - Filter port forwarding resources for docker deploy #9008

Merged

Conversation

jcscottiii
Copy link
Contributor

@jcscottiii jcscottiii commented Aug 10, 2023

Fixes: #9006

Description

Add a filter function to only send port forwarding resources for that particular container into AllocatePort

Add a filter function to only send port resource resources for that particular container into AllocatePort
portForwardResources: nil,
},
{
name: "two artifacts two bindings and two port forward resources",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially, I added a test case to the TestDebugBindings function since it was the only function here. However, I did end up adding a separate function TestFilterPortForwardingResources to test specifically that. Let me know if I should revert the changes in this TestDebugBindings function.

@jcscottiii jcscottiii changed the title Attempt fix at #9006 fix: #9006 - Filter port forwarding resources for docker deploy Aug 10, 2023
@ericzzzzzzz ericzzzzzzz added the kokoro:run runs the kokoro jobs on a PR label Aug 14, 2023
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #9008 (223344b) into main (290280e) will decrease coverage by 6.85%.
Report is 997 commits behind head on main.
The diff coverage is 49.80%.

@@            Coverage Diff             @@
##             main    #9008      +/-   ##
==========================================
- Coverage   70.48%   63.64%   -6.85%     
==========================================
  Files         515      624     +109     
  Lines       23150    31933    +8783     
==========================================
+ Hits        16317    20323    +4006     
- Misses       5776    10081    +4305     
- Partials     1057     1529     +472     
Files Changed Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 415 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz enabled auto-merge (squash) August 14, 2023 12:13
@ericzzzzzzz ericzzzzzzz merged commit 59a928e into GoogleContainerTools:main Aug 14, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple containers in docker deploy result in extra ports being forwarded
3 participants