-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: crd status check #9016
feat: crd status check #9016
Conversation
…e current logic for parsing hydratedManifests
Codecov Report
@@ Coverage Diff @@
## main #9016 +/- ##
==========================================
- Coverage 70.48% 63.46% -7.02%
==========================================
Files 515 624 +109
Lines 23150 32028 +8878
==========================================
+ Hits 16317 20328 +4011
- Misses 5776 10167 +4391
- Partials 1057 1533 +476
... and 416 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
LGTM! I was just wondering if there is a way to have the CRDs logic to manage the ConfigConnector case, I saw we are using different errors codes, but I guess we can discuss it if make sense. Thanks! |
Fixes: #8462
Description
Test Plan
skaffold/pkg/skaffold/kubernetes/manifest/selector.go
Line 62 in 700fd81
test-crds-status-check.tar.gz and untar it
skaffold dev --status-check-selectors selectors.json
should see status check against the crd, the status check against ConfigConnector will hang until check success, this is expected as config controller returns IN_PROGRESS for both resource reconciling and failing.