Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix document tutorials/skaffold-resource-selector.md #9083

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

yosukei3108
Copy link
Contributor

Fixes: N/A
Related: N/A
Merge before/after: N/A

Description

Tweak markdown decorations and make some fixes in tutorials/skaffold-resource-selector.md.

@google-cla
Copy link

google-cla bot commented Sep 9, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@yosukei3108 yosukei3108 changed the title Fix document tutorials/skaffold-resource-selector.md docs: Fix document tutorials/skaffold-resource-selector.md Sep 9, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #9083 (bca59b3) into main (290280e) will decrease coverage by 7.14%.
Report is 1031 commits behind head on main.
The diff coverage is 49.04%.

@@            Coverage Diff             @@
##             main    #9083      +/-   ##
==========================================
- Coverage   70.48%   63.34%   -7.14%     
==========================================
  Files         515      626     +111     
  Lines       23150    32188    +9038     
==========================================
+ Hits        16317    20390    +4073     
- Misses       5776    10253    +4477     
- Partials     1057     1545     +488     
Files Changed Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <0.00%> (ø)
... and 40 more

... and 429 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz merged commit 5e78f53 into GoogleContainerTools:main Sep 15, 2023
14 checks passed
@yosukei3108
Copy link
Contributor Author

@ericzzzzzzz Thanks for the review!

@yosukei3108 yosukei3108 deleted the fix_markdown branch September 15, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants