Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix releaseNoteLink for v2.8.0 #9125

Merged
merged 1 commit into from
Oct 11, 2023
Merged

docs: fix releaseNoteLink for v2.8.0 #9125

merged 1 commit into from
Oct 11, 2023

Conversation

apricote
Copy link
Contributor

Description

Fixes the link to the v2.8.0 changelog on https://skaffold.dev/docs/references/yaml/.

The current link leads to a 404. The actual tag has a v prefix.

User facing changes (remove if N/A)

Follow-up Work (remove if N/A)

The current link leads to a 404. The actual tag has a `v` prefix.
@google-cla
Copy link

google-cla bot commented Oct 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #9125 (164afa0) into main (290280e) will decrease coverage by 7.05%.
Report is 1041 commits behind head on main.
The diff coverage is 48.33%.

@@            Coverage Diff             @@
##             main    #9125      +/-   ##
==========================================
- Coverage   70.48%   63.44%   -7.05%     
==========================================
  Files         515      628     +113     
  Lines       23150    32331    +9181     
==========================================
+ Hits        16317    20511    +4194     
- Misses       5776    10259    +4483     
- Partials     1057     1561     +504     
Files Coverage Δ
cmd/skaffold/app/cmd/commands.go 97.61% <100.00%> (+0.35%) ⬆️
cmd/skaffold/app/cmd/config.go 100.00% <100.00%> (ø)
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/debug.go 100.00% <100.00%> (ø)
cmd/skaffold/app/cmd/flags.go 93.00% <100.00%> (+2.18%) ⬆️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/init.go 100.00% <100.00%> (ø)
... and 41 more

... and 431 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 merged commit 00ebaa2 into GoogleContainerTools:main Oct 11, 2023
14 checks passed
@apricote apricote deleted the patch-1 branch October 26, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants