Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profile): Added profile list command to output available profile names #9294

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

idsulik
Copy link
Contributor

@idsulik idsulik commented Feb 3, 2024

Description
Hi! What do you think about the new command skaffold profile list which will output a list of profile names? In big projects it's quite hard to see all the profiles you can use

User facing changes
Before: You should open a config file to see available profiles
After: You can execute skaffold profile list to see available profiles

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: Patch coverage is 87.87879% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 63.60%. Comparing base (290280e) to head (c421f57).
Report is 1133 commits behind head on main.

❗ Current head c421f57 differs from pull request most recent head a20fb54. Consider uploading reports for the commit a20fb54 to get more accurate results

Files Patch % Lines
cmd/skaffold/app/cmd/profile/list.go 78.94% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9294      +/-   ##
==========================================
- Coverage   70.48%   63.60%   -6.89%     
==========================================
  Files         515      638     +123     
  Lines       23150    32806    +9656     
==========================================
+ Hits        16317    20865    +4548     
- Misses       5776    10333    +4557     
- Partials     1057     1608     +551     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@idsulik
Copy link
Contributor Author

idsulik commented Apr 13, 2024

@ericzzzzzzz Hi!
Should I do anything else or I just need to wait?

@idsulik idsulik force-pushed the feature-profile-list-command branch from c421f57 to a20fb54 Compare April 13, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant