Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exec|verify): enabled "namespace" option for exec and verify commands #9307

Merged
merged 2 commits into from
May 8, 2024

Conversation

idsulik
Copy link
Contributor

@idsulik idsulik commented Feb 10, 2024

Fixes: #9051

Description
Tested and enabled "--namespace" option for verify and exec commands

User facing changes
Before: no "--namespace" available for verify and exec commands
After: "--namespace" is available for verify and exec commands

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.55%. Comparing base (290280e) to head (a112b53).
Report is 1153 commits behind head on main.

❗ Current head a112b53 differs from pull request most recent head 6169386. Consider uploading reports for the commit 6169386 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9307      +/-   ##
==========================================
- Coverage   70.48%   63.55%   -6.93%     
==========================================
  Files         515      635     +120     
  Lines       23150    32804    +9654     
==========================================
+ Hits        16317    20850    +4533     
- Misses       5776    10346    +4570     
- Partials     1057     1608     +551     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@idsulik
Copy link
Contributor Author

idsulik commented May 7, 2024

@ericzzzzzzz hi! Could you please review it?

@ericzzzzzzz ericzzzzzzz self-assigned this May 7, 2024
@ericzzzzzzz ericzzzzzzz added the kokoro:force-run forces a kokoro re-run on a PR label May 7, 2024
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label May 7, 2024
@ericzzzzzzz ericzzzzzzz merged commit 0ffd373 into GoogleContainerTools:main May 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable namespace flag for command verify and exec
3 participants