Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow partial match for manual sync #9344

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

simonstratmann
Copy link

Fixes: #9326

Description
Current behavior: If files someFile.txt and someFile.html are changed and a manual sync pattern *.html exists then no sync is made because the first file does not match.

With this MR partial matches should be correctly recognized.

Follow-up Work (remove if N/A)
Not sure if this approach is correct or if the returned values should be interpreted differently instead of saving the mismatch inside the function.

Copy link

google-cla bot commented Mar 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@simonstratmann
Copy link
Author

I've updated the code and the expectations in the test. To me it looks like the behavior was wrong before but as some of the test code has existed since 2019 I may be misunderstanding the use case.

Please see the first commit that keeps the old expectations mostly intact and the newer commit that updates the tests according to what I would expect to be correct.

@simonstratmann
Copy link
Author

I would love for somebody to review this. The bug is preventing me from using hot deploy in a meaningful manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync with manual mapping not working when multiple files are changed of which the first one is not mapped
1 participant