Fix shortcode issue when no attribute is passed

GoogleForCreators · May 8, 2023 · 1162187 · 1162187
1 parent 6d96d32
commit 1162187
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/includes/Shortcode/Stories_Shortcode.php b/includes/Shortcode/Stories_Shortcode.php
@@ -61,10 +61,10 @@ public function register(): void {
 	 *
 	 * @since 1.5.0
 	 *
-	 * @param array<string,string|int> $attrs Shortcode attributes.
+	 * @param array<string,string|int>|string $attrs Shortcode attributes.
 	 * @return string Story markup.
 	 */
-	public function render_stories( array $attrs ): string {
+	public function render_stories( $attrs ): string {
 		$default_pairs = [
 			'view'               => 'circles',
 			'number_of_columns'  => 1,
@@ -89,6 +89,11 @@ public function render_stories( array $attrs ): string {
 			$default_pairs[ $taxonomy ] = '';
 		}
 
+		// Initialize '$attrs' when not an array OR is an empty string.
+		if ( empty( $attrs ) || ! is_array( $attrs) ) {
+			$attrs = [];
+		}
+
 		$attributes = shortcode_atts(
 			$default_pairs,
 			$attrs,