show input placeholder for default (zero) value

GoogleForCreators · Jun 19, 2023 · 3470a39 · 3470a39
1 parent dc27f6c
commit 3470a39
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/includes/Settings.php b/includes/Settings.php
@@ -242,7 +242,7 @@ public function register(): void {
 			[
 				'description'  => __( 'MGID Widget ID', 'web-stories' ),
 				'type'         => 'integer',
-				'default'      => 0,
+				'default'      => null,
 				'show_in_rest' => true,
 			]
 		);

diff --git a/packages/wp-dashboard/src/components/editorSettings/adManagement/mgid/index.js b/packages/wp-dashboard/src/components/editorSettings/adManagement/mgid/index.js
@@ -51,6 +51,9 @@ export const TEXT = {
 };
 
 function MgidSettings({ widgetId: mgidWidgetId, handleUpdate }) {
+  // fix null error
+  mgidWidgetId = mgidWidgetId ?? '';
+
   const [widgetId, setWidgetId] = useState(mgidWidgetId);
   const [widgetIdInputError, setWidgetIdInputError] = useState('');
   const canSaveWidgetId = widgetId !== mgidWidgetId && !widgetIdInputError;

diff --git a/tests/phpunit/integration/tests/Settings.php b/tests/phpunit/integration/tests/Settings.php
@@ -88,7 +88,7 @@ public function test_on_plugin_uninstall(): void {
 		$this->assertSame( '', get_option( $this->instance::SETTING_NAME_AD_MANAGER_SLOT_ID ) );
 		$this->assertSame( '', get_option( $this->instance::SETTING_NAME_ADSENSE_PUBLISHER_ID ) );
 		$this->assertSame( '', get_option( $this->instance::SETTING_NAME_ADSENSE_SLOT_ID ) );
-		$this->assertSame( 0, get_option( $this->instance::SETTING_NAME_MGID_WIDGET_ID ) );
+		$this->assertSame( null, get_option( $this->instance::SETTING_NAME_MGID_WIDGET_ID ) );
 		$this->assertSame( [], get_option( $this->instance::SETTING_NAME_EXPERIMENTS ) );
 		$this->assertSame( 0, get_option( $this->instance::SETTING_NAME_ACTIVE_PUBLISHER_LOGO ) );
 		$this->assertSame( [], get_option( $this->instance::SETTING_NAME_PUBLISHER_LOGOS ) );