Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3pMedia library accessibility: focus order is inconsistent #10642

Closed
miina opened this issue Feb 21, 2022 · 0 comments · Fixed by #13223
Closed

3pMedia library accessibility: focus order is inconsistent #10642

miina opened this issue Feb 21, 2022 · 0 comments · Fixed by #13223
Labels
Accessibility Changes that impact accessibility and need corresponding review (e.g. markup changes). Group: Library P2 Should do soon Type: Bug Something isn't working

Comments

@miina
Copy link
Contributor

miina commented Feb 21, 2022

Feature Description

When tabbing from a focused media item, canvas gets the focus. However, when doing Shift-Tab then, the 3p media provider link gets the focus instead.

This behaviour should be consistent -- either focus on the attribution after tabbing in focused media item or skip focusing on it.

How to reproduce

  1. Open the 3p media library
  2. Tab into a media item
  3. Tab again
  4. See the focus on Canvas
  5. Now click "Shift + Tab"
  6. The focus is on the Unsplash attribution

Alternatives Considered

Additional Context
@miina miina added Type: Bug Something isn't working Accessibility Changes that impact accessibility and need corresponding review (e.g. markup changes). P2 Should do soon Pod: Prometheus Group: Library labels Feb 21, 2022
@miina miina mentioned this issue Feb 21, 2022
Merged
13 tasks
@miina miina mentioned this issue Mar 9, 2022
Closed
@ayushnirwal ayushnirwal mentioned this issue Apr 19, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accessibility Changes that impact accessibility and need corresponding review (e.g. markup changes). Group: Library P2 Should do soon Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Media: Remove attribution from sequential keyboard navigation GoogleForCreators/web-stories-wp
2 participants
@swissspidy @miina