New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media: Remove attribution from sequential keyboard navigation #13223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +6 B (0%) Total Size: 2.73 MB ℹ️ View Unchanged
|
Plugin builds for 2fd89cb are ready 🛎️!
|
swissspidy
added
Type: Bug
Something isn't working
Accessibility
Changes that impact accessibility and need corresponding review (e.g. markup changes).
Group: 3P Media
Third-party media provider integrations.
labels
Apr 25, 2023
swissspidy
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this makes the attribution links unreachable for keyboard-only users, it seems acceptable in this case.
swissspidy
changed the title
Remove attribution from sequential keyboard navigation
Media: Remove attribution from sequential keyboard navigation
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Accessibility
Changes that impact accessibility and need corresponding review (e.g. markup changes).
Group: 3P Media
Third-party media provider integrations.
Type: Bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Remove attribution component from keyboard navigation with
tabIndex
= -1Summary
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZ
label to the PRFixes #10642