Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript: Convert design system theme #12659

Closed
swissspidy opened this issue Nov 10, 2022 · 0 comments · Fixed by #12929
Closed

TypeScript: Convert design system theme #12659

swissspidy opened this issue Nov 10, 2022 · 0 comments · Fixed by #12929
Assignees
@barklund @kkalarickal
Labels
P2 Should do soon Package: Design System /packages/design-system Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️

Comments

@swissspidy
Copy link
Collaborator

swissspidy commented Nov 10, 2022 •
edited

The theme is heavily used throughout the app and would greatly benefit from improved typing support when using styled components everywhere.

Some previous attempts:

See also https://styled-components.com/docs/api#typescript
@swissspidy swissspidy added P2 Should do soon Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Pod: Prometheus Package: Design System /packages/design-system labels Nov 10, 2022
@barklund barklund self-assigned this Nov 29, 2022
This was referenced Dec 2, 2022
Merged
Merged
@miina miina mentioned this issue Dec 29, 2022
Merged
8 tasks
@barklund barklund mentioned this issue Jan 10, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barklund barklund

@kkalarickal kkalarickal

Labels
P2 Should do soon Package: Design System /packages/design-system Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert design-system package to TypeScript GoogleForCreators/web-stories-wp
3 participants
@barklund @swissspidy @kkalarickal