TypeScript: pageCanvas provider
#12891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miina
added
Type: Code Quality
miina
commented
Dec 28, 2022
|
|
||
| export default createContext({ actions: {}, state: {} }); | ||
| import type { Element } from '@googleforcreators/elements'; |
There was a problem hiding this comment.
Added a declaration file for DisplayElement, otherwise converting the provider is blocked.
miina
commented
Dec 28, 2022
| ...breakpoint, | ||
| raw, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Converted the theme part to TypeScript since it seems to be constants only.
There was a problem hiding this comment.
Thanks git for thinking this is the same file before and after 🙄
miina
commented
Dec 28, 2022
packages/story-editor/src/app/pageCanvas/utils/storyPageToNode.tsx
Outdated
Show resolved
Hide resolved
|
Plugin builds for 496aaff are ready 🛎️!
|
|
Size Change: +3.63 kB (0%) Total Size: 2.71 MB
ℹ️ View Unchanged
|
barklund
approved these changes
Dec 29, 2022
| ...breakpoint, | ||
| raw, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Thanks git for thinking this is the same file before and after 🙄
packages/story-editor/src/app/pageCanvas/getPageWithoutSelection.ts
Outdated
Show resolved
Hide resolved
| height: 100%; | ||
| position: relative; | ||
| overflow: hidden; | ||
| background-color: ${({ theme }) => theme.colors.fg.white}; | ||
| background-color: ${({ theme }) => (theme as typeof ds_theme).colors.standard.white}; |
There was a problem hiding this comment.
Hmm, is that necessary? That should happen automatically if things are correctly set up.
There was a problem hiding this comment.
I didn't set anything up, I just converted the theme constant files into .ts files, nothing else :) Perhaps making sure it works without casting could be part of #12659?
packages/story-editor/src/components/canvas/displayElement.d.ts
Outdated
Show resolved
Hide resolved
|
The failing test fails on |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12667