Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link tooltip preview innacurate #12834

Closed
swissspidy opened this issue Dec 13, 2022 · 0 comments · Fixed by #12840
Closed

Link tooltip preview innacurate #12834

swissspidy opened this issue Dec 13, 2022 · 0 comments · Fixed by #12840
Assignees
@barklund @kkalarickal
Labels
Group: Canvas Group: Links Type: Bug Something isn't working

Comments

@swissspidy
Copy link
Collaborator

Bug Description

Two issues I noticed with link tooltips in the editor:

  1. The tail position is sometimes completely off. It should be more or less in the center of the element
  2. The preview does not match the frontend.
  • If there is no icon, don't show it.
  • Show "external link" icon to the right

Expected Behaviour

More WYSIWYG :)

Steps to Reproduce

  1. Add link to element
  2. Move element around
  3. Compare with story preview

Screenshots

Screenshot 2022-12-13 at 10 45 43

Screenshot 2022-12-13 at 10 45 38

Screenshot 2022-12-13 at 10 45 15

Screenshot 2022-12-13 at 10 45 00

Screenshot 2022-12-13 at 10 44 04

Additional Context

  • Plugin Version: 1.28
  • WordPress Version: 6.1
  • Operating System: macOS
  • Browser: Chrome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barklund barklund

@kkalarickal kkalarickal

Labels
Group: Canvas Group: Links Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed tooltips for element links GoogleForCreators/web-stories-wp
3 participants
@barklund @swissspidy @kkalarickal